fix(NcRichContenteditable): Fix tribute opening and eating input after pasting text#3916
Closed
nickvergessen wants to merge 2 commits intomasterfrom
Closed
fix(NcRichContenteditable): Fix tribute opening and eating input after pasting text#3916nickvergessen wants to merge 2 commits intomasterfrom
nickvergessen wants to merge 2 commits intomasterfrom
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
…r pasting text Pasting content will pop up tribute automatically, when the message starts with a trigger : for emojis @ for mentions / for link picker So we detach tribute before pasting and then attach it again afterwards, so the opened tribute doesn't eat the rest of your message until you press Enter and just "autocomplete" the tribute that has been actively hanging in the top left of the screen Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added
bug
Contributor
|
Works fine. Ready to approve after a decision is take regarding https://github.com/nextcloud/nextcloud-vue/pull/3915/files#r1146092180 |
Contributor
Author
|
Seems we found a better solution in #3917 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pasting content will pop up tribute automatically,
when the message starts with a trigger
So we detach tribute before pasting and then
attach it again afterwards, so the opened tribute
doesn't eat the rest of your message until you press
Enter and just "autocomplete" the tribute that has
been actively hanging in the top left of the screen
Fix #3913
Based on top of #3915 as it is in the same lines